Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key Manager Visibility in Developer Portal #12163

Merged
merged 38 commits into from
Jan 9, 2024
Merged

Key Manager Visibility in Developer Portal #12163

merged 38 commits into from
Jan 9, 2024

Conversation

Kirishikesan
Copy link
Contributor

@Kirishikesan Kirishikesan commented Sep 26, 2023 •
edited
Loading

Overview

This PR consists of

  1. CRUD operations of Key Manager Permissions
  2. API Schema changes in admin portal to include key manager permissions in key manager dto
  3. API Schema changes in publisher portal to include key manager permissions in key manager info dto
  4. API level and Service level implementations related to key manager permissions
  5. Filtering Key Managers for users with respect to their roles and key manager permissions
  6. Restricting key generation for unauthorized users for specific key managers

Resolves wso2/api-manager#2118

@Kirishikesan
Added the DAO layer for Managing KeyManagerPermissions
d1cfc17
@Kirishikesan
Adds KeyManagerPermissionDTO
ca79bbc
@Kirishikesan
Changes in DB layer for KeyManagerPermissions
7ed5efd
@Kirishikesan
Merge branch 'master' of https://github.com/Kirishikesan/carbon-apimgt
8ba9eee
@Kirishikesan
Merge branch 'master' of https://github.com/Kirishikesan/carbon-apimgt
9e11194
@Kirishikesan
Adding the dao calls for key manager permissions
9a74cdb
@Kirishikesan
Adds consumer layer implementation with dao
65dfb48
@Kirishikesan
Adds DTO in admin and publiser portals
876c4a2
@Kirishikesan
Adds database layer
8b03d08
@Kirishikesan
Adds api service layer
f6c5ea3
@Kirishikesan
Adds api schema changes
12c3ac1
@Kirishikesan
Merge branch 'master' of https://github.com/Kirishikesan/carbon-apimgt
3504c89
@Kirishikesan
Removes import all
92ae809
@Kirishikesan
Remove publisher portal role restriction warning
d697fd0
@Kirishikesan
Remove generated KeyManagerInfoDTO changes
ffb742c
@Kirishikesan
Changes KeyManagerPermissionConfigurationDTO schema by reducing redun…
7bca24f 
…dancy of permissionType
@Kirishikesan
Changes KeyManagerPermissionConfigurationDTO by removing permissionTy…
a46dd0a 
…pe redundancy
@Kirishikesan
Changes KeyManagerPermissions CRUD logic to DAO level
fbe9f34
@Kirishikesan
Refactor isKeyManagerAllowedForUser method to be reused
702e01b
@Kirishikesan
Add role validation in rest api level
7ee04c3
@Kirishikesan
Removes unused DAO methods
dc288f9
@Kirishikesan
Changes to adhere to wso2 checkstyle
31c2620
@Kirishikesan
Adding error code for restricted key manager access
1ab19fc
@Kirishikesan
Changes in DB scripts
ed65537
@Kirishikesan
Copy link
Contributor Author

Tests failing for this PR are,

  • JWTBandwidthThrottlingTestCase
  • JWTRequestCountThrottlingTestCase
  • ExternalIDPJWTTestCase
  • CrossTenantSubscriptionTestCase

Test failures are not due to this PR

@Kirishikesan Kirishikesan merged commit 47ef961 into wso2:master Jan 9, 2024
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tharikaGitHub tharikaGitHub tharikaGitHub approved these changes

@tharindu1st tharindu1st Awaiting requested review from tharindu1st tharindu1st is a code owner

@Arshardh Arshardh Awaiting requested review from Arshardh Arshardh is a code owner

@tgtshanika tgtshanika Awaiting requested review from tgtshanika tgtshanika is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Key Manager Visibility in Developer portal
3 participants
@Kirishikesan @tharikaGitHub @Arshardh